Bug 510 - Virtio driver breaks all apps which use ETH_MQ_RX_RSS
Summary: Virtio driver breaks all apps which use ETH_MQ_RX_RSS
Status: UNCONFIRMED
Alias: None
Product: DPDK
Classification: Unclassified
Component: vhost/virtio (show other bugs)
Version: 19.08
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Maxime Coquelin
URL:
Depends on:
Blocks:
 
Reported: 2020-07-17 22:45 CEST by Dan Gora
Modified: 2020-09-16 23:09 CEST (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dan Gora 2020-07-17 22:45:41 CEST 
After commit 13b3137f3b7c8f866947a9b34e06a8a, all applications which set rxmode.mq_mode to ETH_MQ_RX_RSS, _even if only 1 rx queue is set_ fail to open the device.

This includes all the l3fwd examples, distributor, ipsec-secgw, etc..  Not to mention my app.

Since there is no way to determine what flags the PMD will accept for rxmode.mq_mode or txmode.mq_mode, PMDs should accept "invalid" values and ignore them if they are not supported, logging that they are doing so.  

Especially in this case where it is obvious that if there is only one rx queue, then the RX_RSS flag should be ignored.
Comment 1 Ajit Khaparde 2020-09-16 23:09:27 CEST 
Maxime, can you take a look at this? Thanks
Note You need to log in before you can comment on or make changes to this bug.