Bug 997 - a missing check in function "mark_freeable"
Summary: a missing check in function "mark_freeable"
Status: UNCONFIRMED
Alias: None
Product: DPDK
Classification: Unclassified
Component: core (show other bugs)
Version: 21.11
Hardware: All All
: Normal major
Target Milestone: ---
Assignee: dev
URL:
Depends on:
Blocks:
 
Reported: 2022-04-19 05:05 CEST by Yong-Hao Zou
Modified: 2022-04-19 11:43 CEST (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yong-Hao Zou 2022-04-19 05:05:46 CEST 
Hi,

I got a PANIC in "rte_eal_init"

PANIC in rte_eal_init():
Cannot create pipe

It seems there is a missing check in function "mark_freeable", the result of "rte_mem_virt2memseg" is not checked.
Comment 1 Thomas Monjalon 2022-04-19 10:04:15 CEST 
Hi, thank you for reporting an issue.

Please could you explain the condition to reproduce your issue with rte_eal_init?

About "mark_freeable", it is called in "rte_eal_cleanup". Is it related to the issue above?
Comment 2 Yong-Hao Zou 2022-04-19 11:19:52 CEST 
Hi, I'm sorry that it seems the trace is wrong, it does not relate to the "mark_freeable" function. :(

So please ignore the trace, and is the missing check in "mark_freeable" a bug?
Comment 3 Thomas Monjalon 2022-04-19 11:32:00 CEST 
I'm not sure there is a case where rte_mem_virt2memseg can return NULL.
Did you see it happening?
What is the bug you want to fix?
Comment 4 Yong-Hao Zou 2022-04-19 11:43:12 CEST 
I do not see this happen, just see the code during investigating other issues.

And it seems "rte_mem_virt2memseg" is checked in other functions, so maybe it should be checked in "mark_freeable"?
Note You need to log in before you can comment on or make changes to this bug.