Bug 36
Summary: | drivers/bus/pci/linux/pci_vfio.c does not compile when compilation strictly fails on warnings | ||
---|---|---|---|
Product: | DPDK | Reporter: | Raph (dpdk) |
Component: | ethdev | Assignee: | Anatoly Burakov (anatoly.burakov) |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | ajit.khaparde, anatoly.burakov, dpdk |
Priority: | Normal | ||
Version: | 18.05 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Raph
2018-05-03 12:36:30 CEST
DPDK is compiled with all warnings treated as errors by default, so the fact that this hasn't been caught implies you have a non-standard setup that isn't part of our build automation. I think the fix you suggested should be pretty safe, but a safer fix would be to change the name of this internal define to avoid redefining it in the first place. Well, if you consider using 'musl' non-standard (;-). [As things stand, DPDK wouldn't compile on an Alpine Linux, say - the most popular container distro de jour]. Given that musl is a stricter, and, arguably, more robust C lib, it'd be a good CI test to run compiles against it regularly. Raph, Anatoly, What is the next step on this? Thanks The next step would be to fix this :) I've completely forgot about this issue, but i'll send a patch to fix it. Patch submitted: http://patches.dpdk.org/patch/43971/ The patches have been merged. |