This file produces a warning: `dpdk/drivers/bus/pci/linux/pci_vfio.c:38:0: warning: "PAGE_SIZE" redefined`. This is irritatingly when one is compiling with warnings as errors in order to catch more serious bugs (eg implicit function definitions). One potential fix might be to do:- ``` #undef PAGE_SIZE #define PAGE_SIZE (sysconf(_SC_PAGESIZE)) ``` But as I'm not clear on the implications, I can't comment further.
DPDK is compiled with all warnings treated as errors by default, so the fact that this hasn't been caught implies you have a non-standard setup that isn't part of our build automation. I think the fix you suggested should be pretty safe, but a safer fix would be to change the name of this internal define to avoid redefining it in the first place.
Well, if you consider using 'musl' non-standard (;-). [As things stand, DPDK wouldn't compile on an Alpine Linux, say - the most popular container distro de jour]. Given that musl is a stricter, and, arguably, more robust C lib, it'd be a good CI test to run compiles against it regularly.
Raph, Anatoly, What is the next step on this? Thanks
The next step would be to fix this :) I've completely forgot about this issue, but i'll send a patch to fix it.
Over to Anatoly based on comment#4. Thanks
Patch submitted: http://patches.dpdk.org/patch/43971/
The patches have been merged.