[dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create

[Jastrzebski, MichalX K]

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
> Sent: Thursday, October 15, 2015 10:17 AM
> To: Jastrzebski, MichalX K
> Cc: Glynn, Michael J; Kulasek, TomaszX; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
> 
> On 2015/10/14 21:42, Jastrzebski, MichalX K wrote:
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tetsuya Mukawa
> >> Sent: Wednesday, October 14, 2015 3:35 AM
> >> To: Kulasek, TomaszX; dev at dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v5 5/9] null: export eth_dev_null_create
> >>
> >> On 2015/09/30 23:05, Tomasz Kulasek wrote:
> >>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek at intel.com>
> >>> ---
> >>>  drivers/net/null/Makefile                 |    2 +-
> >>>  drivers/net/null/rte_eth_null.c           |    2 +-
> >>>  drivers/net/null/rte_eth_null.h           |   40
> >> +++++++++++++++++++++++++++++
> >>>  drivers/net/null/rte_pmd_null_version.map |    7 +++++
> >>>  4 files changed, 49 insertions(+), 2 deletions(-)
> >>>  create mode 100644 drivers/net/null/rte_eth_null.h
> >> Acked-by: Tetsuya Mukawa <mukawa at igel.co.jp>
> > Hi Tetsuya,
> > Thank You for a review and acking patches.
> > There are 5 remaining patches in a patch-set:
> >
> > [dpdk-dev] [PATCH v5 1/9] bonding: rss dynamic configuration
> > [dpdk-dev] [PATCH v5 6/9] test: dynamic rss configuration
> > [dpdk-dev] [PATCH v5 7/9] bonding: per queue stats
> > [dpdk-dev] [PATCH v5 8/9] doc: fixed spellings and typos
> > [dpdk-dev] [PATCH v5 9/9] doc: dynamic rss configuration for bonding
> >
> > Could You also review them and ack if You agree with that implementation,
> please?
> 
> Hi MichalX,
> 
> I've checked above patches. But I am sorry that I am not a correct
> person to ack your patches.
> To review it correctly, at least knowledge about RSS and bonding PMD are
> needed, but honestly I am not familiar with RSS.
> Is it possible to find a correct person who can ack it?
> 
> BTW, I've checked the patch from the following point of view. It may
> help other reviewers.
> (I've checked after fixing null PMD issues I've found today, please
> check an email I've sent to Tomasz)
>  - No fatal errors are reported by checkpatch.pl.
>     - Some style warnings are reported, but I guess we can ignore it.
>  - No compile error with gcc-4.6/4.7/4.8/4.9/5, clang and icc.
>  - No missing symbol.
>  - No compile error for docs.
>  - No compile error for examples.
> 
> Thanks,
> Tetsuya

Hi Tetsuya,
Thank You very much for verifications and Your comments. 
I will ask maintainers in term of reviewing remaining patches.

Regarding an issue with rte_eth_null.h I think that reordering of patches
4 and 5 may be sufficient. 

Best regards
Michal